[SILGen] Gave arguments lexical lifetimes. #39532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
Previously the declaration and definition of EndBorrowCleanup were both within SILGenExpr.cpp. That prevented the usage of cleanups which end borrow scopes within other files. Here, the declaration is moved to Cleanup.h. The necessary changes are made to SILGenExpr.cpp to keep the definition of member functions in place.
Previously, tests for the generation of lexical borrow scopes when -enable-experimental-lexical-lifetimes is passed had been dumped into the file testing the creation of all borrow scopes. Here, the file containing tests on general borrow scopes is reverted to its original state and a new file dedicated to lexical lifetimes is added. Subsequent tests for SILGen's creation of lexical lifetimes will go into that new file.
When the frontend flag -enable-experimental-lexical-lifetimes is passed, arguments of non-trivial, non-address types get lexical borrow scopes. The borrow scope begins in the function prolog. Usages of the arguments are actually usages of the borrowed value. The borrow scope is ended when the function's scope ends.
nate-chandler
force-pushed
the
lexical_lifetimes/silgen_argument_lifetimes
branch
from
01476a7 to
29faebf
Compare
|
@swift-ci please test |
atrick
approved these changes
Oct 1, 2021
|
@swift-ci please clean test windows platform |
1 similar comment
|
@swift-ci please clean test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the frontend flag -enable-experimental-lexical-lifetimes is passed, arguments of non-trivial, non-address types get lexical borrow scopes. The borrow scope begins in the function prolog. Usages of the arguments are actually usages of the borrowed value. The borrow scope is ended when the function's scope ends.